Added postfix-prefix conversion - #10474
Open
arnavjagia wants to merge 4 commits into
Open
Conversation
for more information, see https://pre-commit.ci
algorithms-keeper
Bot
added
tests are failing
tianyizheng02
requested changes
Oct 15, 2023
Comment on lines
+19
to
+20
| Raises: | ||
| IndexError: If the expression is invalid or contains an invalid operator. |
Contributor
There was a problem hiding this comment.
- Could you add checks in your code for these cases rather than relying on
Stack's IndexError? That way we can have more useful error messages for this algorithm. - Could you add a doctest that tests an invalid expression and a doctest that tests an invalid operator?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added postfix-prefix conversion
Checklist: